Fixed the startDate to endDate on start input #16936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisonjoseph
approved these changes
Jul 10, 2024
Merged
via the queue into
carbon-design-system:main
with commit Jul 11, 2024
c1822dc
22 checks passed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16734
After the upgrade from 4.6.9 to 4.6.13 in flatpickr by renovate we started to have a couple new issues in our
DatePickercomponent.I'm reverting the changes from this PR and fixing the issue by validating the
dates.length, so the dates cannot be changed unless the user clicks or writes a date.@riddhybansal I would love your feedback in this one, to make sure I didn't miss anything. The test you wrote is passing, so must be fine.
Changelog
Changed
Testing / Reviewing
StackBlitz example that I copied to use in the storybook
startDate to endDate.xx/01/2001doesn't happen anymore