Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tag): fixes disabled label styles #16943

Merged
merged 6 commits into from
Jul 25, 2024

Conversation

lluisrojass
Copy link
Contributor

Closes #16942

Fixes read only tag disabled state.

Changelog

New

  • _tag.scss adds disabled styles directly to .cds--tag__label element in order to overwrite <DefinitionTooltip /> styles which would usurp .cds--tag--disabled

Changed

  • Removes the type class name from the label (this is still applied via tagClasses)

Testing / Reviewing

  • Validate Tag UI

@lluisrojass lluisrojass requested a review from a team as a code owner July 10, 2024 20:30
Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b51f8e1
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/669e4678a4c1af000855ecdf
😎 Deploy Preview https://deploy-preview-16943--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit b51f8e1
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/669e467824b47c0008b06155
😎 Deploy Preview https://deploy-preview-16943--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@riddhybansal riddhybansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing !! LGTM 💯

Copy link
Contributor

@2nikhiltom 2nikhiltom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 , a review from a designer will solidify this change

@2nikhiltom 2nikhiltom requested a review from thyhmdo July 22, 2024 11:55
Copy link
Contributor

@preetibansalui preetibansalui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guidari guidari added this pull request to the merge queue Jul 25, 2024
Merged via the queue into carbon-design-system:main with commit 299e624 Jul 25, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: <Tag /> disabled state is broken
5 participants