Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useId): make react 18 import impossible to statically analyze #17088

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

tay1orjones
Copy link
Member

Closes #17084

Changelog

Changed

Testing / Reviewing

  • Snapshots should not need updated, meaning id's should be generated the exact same as they were before

@tay1orjones tay1orjones requested a review from a team as a code owner August 1, 2024 18:43
@tay1orjones tay1orjones requested review from emyarod and guidari August 1, 2024 18:43
Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0197242
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66abdb7d6a16c000082e6583
😎 Deploy Preview https://deploy-preview-17088--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 0197242
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66abdb7d691e8500085d1dd6
😎 Deploy Preview https://deploy-preview-17088--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested locally and it is working fine! 🚀

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@tay1orjones tay1orjones enabled auto-merge August 1, 2024 19:11
@tay1orjones tay1orjones added this pull request to the merge queue Aug 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 1, 2024
@tay1orjones tay1orjones added this pull request to the merge queue Aug 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 1, 2024
@tay1orjones tay1orjones merged commit 560d57f into carbon-design-system:main Aug 1, 2024
22 checks passed
tay1orjones added a commit to tay1orjones/carbon that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: useId giving warning as it's not supported by react <18
3 participants