Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 14831 fix calendar icon css issue #17130

Closed
wants to merge 3 commits into from
Closed

fix: 14831 fix calendar icon css issue #17130

wants to merge 3 commits into from

Conversation

NabeelAyubee
Copy link
Contributor

@NabeelAyubee NabeelAyubee commented Aug 9, 2024

Closes #16446

-Calendar icon CSS issue fix when inline props is true
-DatePicker story added with inline props true

Changelog

New
-Added story for DatePicker with inline true in storybook

Changed

  • Changed flatpickr calendar position to absolute and inset block start to auto

Testing / Reviewing

  • Tested in storybook when inline props is set to true. calendar icon is showing correctly

@NabeelAyubee NabeelAyubee requested a review from a team as a code owner August 9, 2024 05:41
Copy link
Contributor

github-actions bot commented Aug 9, 2024

All contributors have signed the DCO.
Posted by the DCO Assistant Lite bot.

Copy link

netlify bot commented Aug 9, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 30a0d5f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66b7504a9220c60008e0b377
😎 Deploy Preview https://deploy-preview-17130--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 9, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 30a0d5f
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66b7504ae3de59000866a41e
😎 Deploy Preview https://deploy-preview-17130--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NabeelAyubee
Copy link
Contributor Author

Hi @tay1orjones ,can you please review this PR for calendar icon fix when inline props is true

@NabeelAyubee NabeelAyubee requested review from a team as code owners August 10, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Calendar icon in Datepicker input got displaced when providing the prop inline to true
1 participant