Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update scss files to follow new ruleset for nested styles from 1.77.7 #17140

Closed

Conversation

Gururajj77
Copy link
Contributor

Closes #16962

refactored the scss file to follow new breaking change which is enforced from the sass' version 1.77.7

Changelog

New

  • updated package.json files with new version which include sass as a dependency

Changed

  • refactored _accordion.scss file where the @include are moved to the last of the scope, and added &{} for styles after nested rules.

Testing / Reviewing

@Gururajj77 Gururajj77 requested a review from a team as a code owner August 12, 2024 09:59
Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6b27cb1
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66b9dce9b696fb0008f0d450
😎 Deploy Preview https://deploy-preview-17140--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 6b27cb1
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66b9dce94c5783000820d01f
😎 Deploy Preview https://deploy-preview-17140--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: [email protected] Mixed Declarations deprecation warning in @carbon/react
1 participant