-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(popover): prevent toggletip ref error #17225
fix(popover): prevent toggletip ref error #17225
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No warning in console anymore, and the logic is more readable now 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
3dc4a27
Reported in slack, this fixes Popover so that it won't incorrectly clone a ToggletipContent child.
The condition was a bit strange and took me a bit to wrap my head around, so I also broke the logic out into something more verbose. I think it helps with readability and being able to more easily understand what's going on there, let me know what you think!
Changelog
New
Changed
Testing / Reviewing