Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14299-docs/treeview-storybook-mdx #17252

Merged

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Aug 22, 2024

Closes #14299

This PR adds the existing MDX file to the TreeView story and updates some of the examples to include demos

Changelog

Changed

  • update TreeView Storybook MDX

Testing / Reviewing

View the TreeView overview story

@emyarod emyarod requested a review from a team as a code owner August 22, 2024 20:32
Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit e6f98ee
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66c7a054e16b1900084b7753
😎 Deploy Preview https://deploy-preview-17252--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit e6f98ee
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66c7a0542394780008240179
😎 Deploy Preview https://deploy-preview-17252--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one minor heads up

The `renderIcon` prop can be used to customize the icons of each node in the TreeView.

<Canvas>
<Story of={TreeViewStories.WithCustomIcons} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up, in #16910 this api is changing. If that's merged first, this will need updated. If this PR is merged first @guidari this will be a new spot to fix in #16910

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge it and then fix it

@guidari guidari added this pull request to the merge queue Aug 23, 2024
Merged via the queue into carbon-design-system:main with commit 53b8b3a Aug 23, 2024
22 checks passed
@emyarod emyarod deleted the 14299-docs/treeview-storybook-mdx branch September 4, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: Improve Treeview developer docs
3 participants