-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dismissible Tag #17345
Dismissible Tag #17345
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (looks like a merge conflict in the story file)
7f9d9b7
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17345 +/- ##
==========================================
- Coverage 76.83% 76.82% -0.02%
==========================================
Files 408 408
Lines 13949 13958 +9
Branches 4276 4337 +61
==========================================
+ Hits 10718 10723 +5
- Misses 3058 3061 +3
- Partials 173 174 +1 ☔ View full report in Codecov by Sentry. |
Hey there! v11.66.0 was just released that references this issue/PR. |
Closes #17107
Closes #17338
Closes #16959
Fixed issue where the screen reader announced [object, object] by checking if the children is a string or not. And added new features to the Dismissible Tag before moving to stable.
Changelog
New
tagTitle
so users can define a customtitle
to the tag.Removed
title
from button because we are have theTooltip
Testing / Reviewing