Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismissible Tag #17345

Merged
merged 10 commits into from
Sep 11, 2024
Merged

Dismissible Tag #17345

merged 10 commits into from
Sep 11, 2024

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Sep 5, 2024

Closes #17107
Closes #17338
Closes #16959

Fixed issue where the screen reader announced [object, object] by checking if the children is a string or not. And added new features to the Dismissible Tag before moving to stable.

Changelog

New

  • Now the Dismissible Tag can be dismissible in the stories
  • New prop called tagTitle so users can define a custom title to the tag.

Removed

  • Removed title from button because we are have the Tooltip

Testing / Reviewing

  • Use VO to test. You should not hear [object, object]
  • Test the dismissible functionality.

@guidari guidari requested a review from a team as a code owner September 5, 2024 17:31
@guidari guidari changed the title Dismissible Tag WIP: Dismissible Tag Sep 5, 2024
Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 9ab4fce
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66e1cf39ae578000082eb720
😎 Deploy Preview https://deploy-preview-17345--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9ab4fce
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66e1cf397943610008f2a4e9
😎 Deploy Preview https://deploy-preview-17345--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@guidari guidari requested a review from a team as a code owner September 5, 2024 18:52
@guidari guidari changed the title WIP: Dismissible Tag Dismissible Tag Sep 5, 2024
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (looks like a merge conflict in the story file)

@guidari guidari added this pull request to the merge queue Sep 11, 2024
Merged via the queue into carbon-design-system:main with commit 7f9d9b7 Sep 11, 2024
23 checks passed
@guidari guidari deleted the 17338-dismissible branch September 11, 2024 17:59
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 76.82%. Comparing base (cfba956) to head (9ab4fce).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/react/src/components/Tag/Tag.tsx 50.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17345      +/-   ##
==========================================
- Coverage   76.83%   76.82%   -0.02%     
==========================================
  Files         408      408              
  Lines       13949    13958       +9     
  Branches     4276     4337      +61     
==========================================
+ Hits        10718    10723       +5     
- Misses       3058     3061       +3     
- Partials      173      174       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carbon-automation
Copy link
Contributor

Hey there! v11.66.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants