Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript types to fluidSelect and fluidSkeleton #17369

Conversation

riddhybansal
Copy link
Contributor

@riddhybansal riddhybansal commented Sep 6, 2024

Closes #17360

Add typescript types to fluidSelect and fluidSkeleton

Changelog

Changed

  • Add typescript types to fluidSelect and fluidSkeleton
  • Converted index.js to index.tsx

Testing / Reviewing

FluidSelect and FluidSelectSkeleton should have typescript support and should work as intended

@riddhybansal riddhybansal requested a review from a team as a code owner September 6, 2024 11:44
Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4888a4f
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66daeb149f14b60008aa097f
😎 Deploy Preview https://deploy-preview-17369--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 4888a4f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66daeb141b08ab0008e15dae
😎 Deploy Preview https://deploy-preview-17369--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 0ee9c27
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66e17cc7ccbe810008cc678c
😎 Deploy Preview https://deploy-preview-17369--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0ee9c27
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66e17cc7ee7c7a00084e4605
😎 Deploy Preview https://deploy-preview-17369--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@riddhybansal riddhybansal added this pull request to the merge queue Sep 12, 2024
Merged via the queue into carbon-design-system:main with commit 47618cc Sep 12, 2024
23 checks passed
@riddhybansal riddhybansal deleted the fluidselect_typescript_types branch September 12, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript types to FluidSelect and its skeleton state
3 participants