Add typescript types to fluid number input #17373
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17373 +/- ##
==========================================
- Coverage 76.83% 76.83% -0.01%
==========================================
Files 408 408
Lines 13945 13946 +1
Branches 4323 4323
==========================================
Hits 10715 10715
Misses 3056 3056
- Partials 174 175 +1 ☔ View full report in Codecov by Sentry. |
c49b590
| import { FluidNumberInputProps } from './FluidNumberInput'; | ||
| import { FluidNumberInputSkeletonProps } from './FluidNumberInput.Skeleton'; | ||
| export { type FluidNumberInputProps, type FluidNumberInputSkeletonProps }; |
There was a problem hiding this comment.
@riddhybansal in addition to the export, the type identifier needs to be on the import statements as well.
I think this should resolve the "The exported identifier "FluidNumberInputProps" is not declared in Babel's scope tracker as a JavaScript value binding, ..." errors
Closes #17362
Add typescript types to FluidNumberInput, FluidNumberInputSkeleton, and converted index.js to index.tsx file
Changelog
Changed
Testing / Reviewing
Test if FluidNumberInput, FluidNumberInputSkeleton works as intended after adding types