-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typescript types FluidTimePicker and FluidTimePickerSelect #17445
Add typescript types FluidTimePicker and FluidTimePickerSelect #17445
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17445 +/- ##
==========================================
+ Coverage 76.92% 76.95% +0.02%
==========================================
Files 408 408
Lines 13979 13980 +1
Branches 4291 4344 +53
==========================================
+ Hits 10754 10758 +4
+ Misses 3052 3049 -3
Partials 173 173 ☔ View full report in Codecov by Sentry. |
Hi there I have one doubt over here I ahve passes id as empty string as it is a required prop, Can we do anything else instead of it ? |
@riddhybansal I think FluidTimePickerProps needs to extend/inherit FluidTextInputProps |
packages/react/src/components/FluidTimePicker/__tests__/FluidTimePicker-test.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
f6b19e1
Closes #17358
Closes #17359
Added Typescript types to FluidTimePicker and FluidTimePickerSelect and their skeleton state
Changelog
New
Added Typescript types to FluidTimePicker and FluidTimePickerSelect and there skeleton state
Converted index.js to tsx for both the component
Testing / Reviewing
FluidTimePicker and FluidTimePickerSelect and their skeleton state should work as intended with typescript support