-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: focus-trapped-within-menuitem #17550
fix: focus-trapped-within-menuitem #17550
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17550 +/- ##
=======================================
Coverage 77.03% 77.03%
=======================================
Files 408 408
Lines 13992 13992
Branches 4300 4300
=======================================
Hits 10779 10779
Misses 3040 3040
Partials 173 173 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome ! This avoids keyboard navigation to cause page scroll too
afc2c6a
Hey there! v11.67.0 was just released that references this issue/PR. |
Closes #17277
Focus trapped in menuItem of menuButton
Changelog
Changed
place e.preventDefault to required condition only instead of whole focus method.
Testing / Reviewing
To test focus trapped issue
To test Scroll issue