fix(date-picker): clearing input and selecting a date #17669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17669 +/- ##
==========================================
+ Coverage 77.07% 77.10% +0.02%
==========================================
Files 409 409
Lines 14021 14027 +6
Branches 4307 4330 +23
==========================================
+ Hits 10807 10815 +8
+ Misses 3044 3041 -3
- Partials 170 171 +1 ☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Merged
via the queue into
carbon-design-system:main
with commit Oct 9, 2024
f10cb92
36 checks passed
|
Hey there! v11.68.0 was just released that references this issue/PR. |
annawen1
pushed a commit
to annawen1/carbon
that referenced
this pull request
Oct 11, 2024
…system#17669) * fix(date-picker): keep open when clearing input * fix(date-picker): add type single to condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14529
When opening the date-picker, then clearing the input in date-picker and then clicking on a value the date-picker would still show empty.
Screen.Recording.2024-10-01.at.9.45.51.AM.mov
Screen.Recording.2024-10-01.at.9.44.49.AM.mov
Changelog
Changed
Testing / Reviewing
make sure tests still pass. make sure works similiarly to flatpickr examples
Open storybook