Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(staticnotification): remove staticnotification from top of sidebar #17673

Merged

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Oct 7, 2024

Fixes the sidebar so StaticNotification docs page sits in it's proper spot in the left nav instead of being at the top

image

Related #17443

Changelog

Changed

  • Mark the docs .mdx page as a template so storybook handles it properly

Testing / Reviewing

  • Deploy preview should show that it sits in the correct spot and is not like the above screenshot anymore

Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 7b60087
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67043ef8ca8fba0008dd2d8e
😎 Deploy Preview https://deploy-preview-17673--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 7b60087
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67043ef85978f30008012c53
😎 Deploy Preview https://deploy-preview-17673--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.08%. Comparing base (f232cb6) to head (7b60087).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17673   +/-   ##
=======================================
  Coverage   77.08%   77.08%           
=======================================
  Files         409      409           
  Lines       14023    14023           
  Branches     4355     4327   -28     
=======================================
  Hits        10809    10809           
+ Misses       3044     3043    -1     
- Partials      170      171    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tay1orjones tay1orjones added this pull request to the merge queue Oct 8, 2024
Merged via the queue into carbon-design-system:main with commit c788f34 Oct 8, 2024
23 checks passed
@tay1orjones tay1orjones deleted the fix-staticnotification-docs branch October 8, 2024 14:07
@carbon-automation
Copy link
Contributor

Hey there! v11.68.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants