-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(staticnotification): remove staticnotification from top of sidebar #17673
fix(staticnotification): remove staticnotification from top of sidebar #17673
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17673 +/- ##
=======================================
Coverage 77.08% 77.08%
=======================================
Files 409 409
Lines 14023 14023
Branches 4355 4327 -28
=======================================
Hits 10809 10809
+ Misses 3044 3043 -1
- Partials 170 171 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
c788f34
Hey there! v11.68.0 was just released that references this issue/PR. |
Fixes the sidebar so StaticNotification docs page sits in it's proper spot in the left nav instead of being at the top
Related #17443
Changelog
Changed
Testing / Reviewing