fix(slider): disabled focus and styles #17675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17675 +/- ##
==========================================
+ Coverage 77.08% 77.36% +0.27%
==========================================
Files 409 409
Lines 14023 14077 +54
Branches 4355 4324 -31
==========================================
+ Hits 10809 10890 +81
+ Misses 3044 3018 -26
+ Partials 170 169 -1 ☔ View full report in Codecov by Sentry. |
kennylam
approved these changes
Oct 14, 2024
Merged
via the queue into
carbon-design-system:main
with commit Oct 14, 2024
9a4c29b
36 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16633
When putting the slider in a disabled state the user could still focus to it. This updates so you can no longer focus on the element when it's disabled.
Also, the disabled styles looked a bit off for two sliders
before:
after:
Changelog
New
tabIndexChanged
Testing / Reviewing
go to slider stories and turn on disabled state
since the controls aren't turned on for the two sliders I tested it locally in storybook but updating a story with the prop
disabled