fix(Notification): remove tabindex on close buttons #17852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17852 +/- ##
=======================================
Coverage 80.19% 80.19%
=======================================
Files 406 406
Lines 14040 14040
Branches 4347 4347
=======================================
Hits 11260 11260
Misses 2614 2614
Partials 166 166 ☔ View full report in Codecov by Sentry. |
alisonjoseph
approved these changes
Oct 23, 2024
ariellalgilmore
approved these changes
Oct 23, 2024
ariellalgilmore
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
|
looks like some tests are failing? |
emyarod
force-pushed
the
15907-fix/remove-notification-close-button-tabindex
branch
from
540691d to
23d538f
Compare
emyarod
force-pushed
the
15907-fix/remove-notification-close-button-tabindex
branch
from
23d538f to
c3bfceb
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
carbon-design-system:main
with commit Oct 25, 2024
0810fa1
40 checks passed
emyarod
deleted the
15907-fix/remove-notification-close-button-tabindex
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15907
this PR updates the notification components so that the buttons to dismiss the notifications are accessible via keyboard
Changelog
Changed
Removed
Testing / Reviewing
view the notification stories and confirm that the close buttons are accessible via keyboard