-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vite migration #17860
base: main
Are you sure you want to change the base?
Vite migration #17860
Conversation
* begin to replace webpack with vite - updating story book config
* add vite configuration in storybook * update storybook dependencies
* remove unused code
* remove console logs, reinstall and rebuild
* revert changes to feature flag * uninstall vite-tsconfig-paths which was unnecessary * remove comments
* revert changes to feature flag * uninstall vite-tsconfig-paths which was unnecessary * remove comments
* fix issue with @storybook/addon-essentials docs overriding remarkGfm
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
* remove unused style config * revert change to storybook accessibility checker library
Hi @guidari, thanks for having a look at this already. I was referencing the work you linked as I was drafting this up. I don't think I'm experiencing the same problems that you were with the |
Hey @Neues |
Hi @guidari, no, I was able to run this locally and I wasn't seeing any errors when doing so. Try running |
Weird, mine isn't working 🤔 |
Ok yeah, I also saw the issue after merging in from main. I found this in the FAQ and was able to get it working. I bumped the versions up to latest as well, should be using vite@6 now. It was running for me locally. |
Cool! I was able to run Storybook without errors. I also ran I guess we just have to figure it out why the building isn't working. |
Closes #
Replaces Storybook Webpack builder with Vite, providing faster startup and refresh times.
Changelog
New
Changed
Removed
Testing / Reviewing
yarn install
yarn build
, and if this fails,yarn rebuild
cd packages/react
yarn storybook