Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(code-connect): update version, add fluid search skeleton and code snippet disabled states #17904

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Oct 29, 2024

Ref #17682

Changelog

  • update to latest code connect 1.2.1
  • add disabled state to code connect for code snippet
  • add fluid search skeleton

@alisonjoseph alisonjoseph changed the title Code connect figma sync 17682 fix(code-connect): update version, add FluidSearchSkeleton and CodeSnippet disabled states Oct 29, 2024
@alisonjoseph alisonjoseph changed the title fix(code-connect): update version, add FluidSearchSkeleton and CodeSnippet disabled states fix(code-connect): update version, add fluid search skeleton and code snippet disabled states Oct 29, 2024
Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 86eb683
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67210bcd66449f000895c32d
😎 Deploy Preview https://deploy-preview-17904--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 86eb683
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67210bcd22e23b00082968e7
😎 Deploy Preview https://deploy-preview-17904--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 86eb683
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67210bcd92bf1a00081905f6
😎 Deploy Preview https://deploy-preview-17904--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alisonjoseph alisonjoseph marked this pull request as ready for review October 29, 2024 14:21
@alisonjoseph alisonjoseph requested a review from a team as a code owner October 29, 2024 14:21
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.16%. Comparing base (6dc14bd) to head (86eb683).
Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17904   +/-   ##
=======================================
  Coverage   81.16%   81.16%           
=======================================
  Files         406      406           
  Lines       14046    14046           
  Branches     4403     4374   -29     
=======================================
  Hits        11400    11400           
  Misses       2479     2479           
  Partials      167      167           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alisonjoseph alisonjoseph added this pull request to the merge queue Nov 5, 2024
Merged via the queue into carbon-design-system:main with commit ba6bf6d Nov 5, 2024
40 checks passed
@alisonjoseph alisonjoseph deleted the code-connect-figma-sync-17682 branch November 5, 2024 21:14
@carbon-automation
Copy link
Contributor

Hey there! v11.70.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants