fix: arrow breaking in AILabel popover #17982
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17982 +/- ##
==========================================
- Coverage 83.36% 83.36% -0.01%
==========================================
Files 404 404
Lines 14344 14350 +6
Branches 4646 4655 +9
==========================================
+ Hits 11958 11963 +5
+ Misses 2225 2224 -1
- Partials 161 163 +2 ☔ View full report in Codecov by Sentry. |
Thanks Anna for noticing this. It was caused by recent renaming of slug to ai-label, which is fixed now. |
preetibansalui
added
status: visual review 🔍
and removed
status: visual review 🔍
labels
| alignmentAxis: alignmentAxisOffset, | ||
| mainAxis: popoverDimensions?.current?.offset, |
There was a problem hiding this comment.
This isn't something blocking this PR and doesn't need changed, but one concern I just mentioned a comment on #17003 (comment) is that as we add more of these config values, they bloat the interface/api of these components. Especially when we haven't identified a use case from a consumer for this, it's just something we need internally for our use w/ AILabel.
The mainAxis offset is already pulled from a custom property instead of a prop value. Doing this for other values as well might be one way to scale these types of config values without having to have a prop for each one. Could be used in tandem w/ however we end up providing a way for consumers to config floating-ui from anywhere in their react tree.
There was a problem hiding this comment.
I understood your point, I added a prop here instead of some calculations so that it could be changed to different cases as well which might come in future as we have now for AILabel.
tay1orjones
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: one more review 👀
labels
1cf7200
Closes #17965
Arrow looks breaking in the AI explainability popover in case of small icons.
Changelog
added alignmentAxis in offset for popover.
Changed
passing a prop from AILabel to Toggletip component in case of 'XS', '2xs' or 'mini' icon.
Testing / Reviewing