Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(text-area/input): add new decorator prop #18050

Conversation

ariellalgilmore
Copy link
Member

Closes #17998
Closes #17999

Updates TextArea and TextInput to include new decorator prop

Changelog

New

  • new decorator prop, classes, and styles

Changed

  • deprecated slug prop
  • update rendering slug to render the decorator component but still set the size and styles if it's an AILabel
  • updated tests

Testing / Reviewing

Check TextArea and TextInput with AILabel storybook and check the Form with AILabel storybook

TODO:

  • remove TextArea with tooltip before merging!
  • remove TextInput with tooltip before merging!

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 57fa54f
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67362902140d8b0008fb7d2a
😎 Deploy Preview https://deploy-preview-18050--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit b5ae6e8
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/673386d9fb579b0008ee5f9d
😎 Deploy Preview https://deploy-preview-18050--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit b5ae6e8
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/673386d986ccbf0008c7b319
😎 Deploy Preview https://deploy-preview-18050--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 57fa54f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/673629020d444d0008310e23
😎 Deploy Preview https://deploy-preview-18050--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 57fa54f
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67362902cdae7000084d8a40
😎 Deploy Preview https://deploy-preview-18050--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.17%. Comparing base (5cf7bff) to head (57fa54f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18050      +/-   ##
==========================================
+ Coverage   82.10%   82.17%   +0.07%     
==========================================
  Files         404      404              
  Lines       14107    14137      +30     
  Branches     4426     4458      +32     
==========================================
+ Hits        11582    11617      +35     
+ Misses       2363     2358       -5     
  Partials      162      162              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ariellalgilmore ariellalgilmore marked this pull request as ready for review November 12, 2024 18:10
@ariellalgilmore ariellalgilmore requested review from a team as code owners November 12, 2024 18:10
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@riddhybansal riddhybansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM !!

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ariellalgilmore ariellalgilmore added this pull request to the merge queue Nov 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2024
@ariellalgilmore ariellalgilmore added this pull request to the merge queue Nov 14, 2024
Merged via the queue into carbon-design-system:main with commit a71c1b4 Nov 14, 2024
40 checks passed
@ariellalgilmore ariellalgilmore deleted the feat/text-area-input-decorator branch November 14, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decorator: TextInput Decorator: TextArea
5 participants