Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): a11y: stop SR announcement for hidden labels #18061

Closed
wants to merge 6 commits into from

Conversation

2nikhiltom
Copy link
Contributor

Closes #16613

SR should not announce the label when hideLabel is true

Changelog

New
Added aria-hidden attribute

Testing / Reviewing

Open From the Select - playground story
set the hide label Boolean to "True" and observe the SR do not announce label.

@2nikhiltom 2nikhiltom requested a review from a team as a code owner November 13, 2024 13:45
Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 80832bd
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/673b3724ce8c7000084c70e5
😎 Deploy Preview https://deploy-preview-18061--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 80832bd
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/673b37249d8d620008f370d1
😎 Deploy Preview https://deploy-preview-18061--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 80832bd
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/673b37244c8f6f00085bc39a
😎 Deploy Preview https://deploy-preview-18061--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.19%. Comparing base (6972097) to head (80832bd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18061   +/-   ##
=======================================
  Coverage   82.19%   82.19%           
=======================================
  Files         404      404           
  Lines       14151    14151           
  Branches     4468     4468           
=======================================
  Hits        11631    11631           
  Misses       2359     2359           
  Partials      161      161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@2nikhiltom
Copy link
Contributor Author

Gower confirmed in CAG call that the label has to be announced, otherwise that might lead to a11y issues.

@2nikhiltom 2nikhiltom closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant