fix(Stack): spread inline styles #18067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18067 +/- ##
=======================================
Coverage 84.16% 84.16%
=======================================
Files 404 404
Lines 14350 14350
Branches 4619 4653 +34
=======================================
Hits 12077 12077
Misses 2111 2111
Partials 162 162 ☔ View full report in Codecov by Sentry. |
emyarod
force-pushed
the
17049-fix/stack-spread-styles
branch
from
fd5787f to
e892d98
Compare
ariellalgilmore
approved these changes
Nov 19, 2024
Merged
via the queue into
carbon-design-system:main
with commit Dec 11, 2024
fc76fa7
37 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17049
This PR fixes support for spreading inline styles on the Stack component
Changelog
Changed
styleprop spreadingTesting / Reviewing
add custom styles via the
styleprop and confirm that they're attached to the Stack component