Increase code coverage for multiselect component #18146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18146 +/- ##
==========================================
+ Coverage 83.69% 83.73% +0.04%
==========================================
Files 404 404
Lines 14350 14350
Branches 4599 4599
==========================================
+ Hits 12010 12016 +6
+ Misses 2178 2172 -6
Partials 162 162 ☔ View full report in Codecov by Sentry. |
|
Hi @soumyaraju , if possible could you please write more tests?? |
|
Hi @Gururajj77, i have added few more tests, could you check? |
Gururajj77
approved these changes
Dec 6, 2024
2nikhiltom
approved these changes
Dec 6, 2024
ariellalgilmore
approved these changes
Dec 6, 2024
Merged
via the queue into
carbon-design-system:main
with commit Dec 6, 2024
5c44a20
37 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17480
Added test cases for improving code coverage of multiselect