Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(combobox): use enum for state change types #18154

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

a88zach
Copy link
Contributor

@a88zach a88zach commented Nov 25, 2024

Closes #

#18145

Webpack will optimize code size and will sometimes convert string enums to integers. This change uses the enum from Downshift so that if Webpack converts the string enum to integers, all code will be converted correctly

@a88zach a88zach requested a review from a team as a code owner November 25, 2024 15:23
Copy link
Contributor

github-actions bot commented Nov 25, 2024

All contributors have signed the DCO.
Posted by the DCO Assistant Lite bot.

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 86b6425
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67449e62c58f7700088fb39b
😎 Deploy Preview https://deploy-preview-18154--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@a88zach
Copy link
Contributor Author

a88zach commented Nov 25, 2024

I have read the DCO document and I hereby sign the DCO.

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 86b6425
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67449e62b2130f0008f863f5
😎 Deploy Preview https://deploy-preview-18154--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 86b6425
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67449e625a6a8600083e86a6
😎 Deploy Preview https://deploy-preview-18154--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.22%. Comparing base (f2ba3fd) to head (86b6425).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18154   +/-   ##
=======================================
  Coverage   83.22%   83.22%           
=======================================
  Files         404      404           
  Lines       14338    14338           
  Branches     4645     4641    -4     
=======================================
  Hits        11933    11933           
  Misses       2243     2243           
  Partials      162      162           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing that! LGTM 🚀

The .all-contributorsrc file has some changes, mostly it is format. Can you just rollback that, just to keep as it was. You can add your lines and save without format.

@a88zach
Copy link
Contributor Author

a88zach commented Nov 28, 2024

Thanks for doing that! LGTM 🚀

The .all-contributorsrc file has some changes, mostly it is format. Can you just rollback that, just to keep as it was. You can add your lines and save without format.

I can, but I'm out of office until next week

Copy link
Contributor

@Gururajj77 Gururajj77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Gururajj77 Gururajj77 added this pull request to the merge queue Dec 2, 2024
Merged via the queue into carbon-design-system:main with commit 140794c Dec 2, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants