-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(combobox): use enum for state change types #18154
Conversation
All contributors have signed the DCO. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I have read the DCO document and I hereby sign the DCO. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18154 +/- ##
=======================================
Coverage 83.22% 83.22%
=======================================
Files 404 404
Lines 14338 14338
Branches 4645 4641 -4
=======================================
Hits 11933 11933
Misses 2243 2243
Partials 162 162 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing that! LGTM 🚀
The .all-contributorsrc
file has some changes, mostly it is format. Can you just rollback that, just to keep as it was. You can add your lines and save without format.
I can, but I'm out of office until next week |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
140794c
Closes #
#18145
Webpack will optimize code size and will sometimes convert string enums to integers. This change uses the enum from Downshift so that if Webpack converts the string enum to integers, all code will be converted correctly