Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layer): stories missing import in wc #18252

Conversation

ariellalgilmore
Copy link
Member

Closes #18052

If you refreshed the stories that had with layer it wouldn't always load properly

Changelog

New

  • added missing layer component import in the sb-template-layers

Testing / Reviewing

@ariellalgilmore ariellalgilmore added the package: @carbon/web-components @carbon/web-components label Dec 12, 2024
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner December 12, 2024 16:33
Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit bb07c00
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/675b1df147ae9e000867f2ca
😎 Deploy Preview https://deploy-preview-18252--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit bb07c00
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/675b1df140bae900082ae81c
😎 Deploy Preview https://deploy-preview-18252--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit bb07c00
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/675b1df122ceb60008d6fa0f
😎 Deploy Preview https://deploy-preview-18252--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.31%. Comparing base (812d029) to head (bb07c00).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18252   +/-   ##
=======================================
  Coverage   84.31%   84.31%           
=======================================
  Files         404      404           
  Lines       14352    14352           
  Branches     4601     4601           
=======================================
  Hits        12101    12101           
  Misses       2090     2090           
  Partials      161      161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow good find!!

@annawen1 annawen1 enabled auto-merge December 16, 2024 16:10
@annawen1 annawen1 added this pull request to the merge queue Dec 16, 2024
Merged via the queue into carbon-design-system:main with commit 2c2bbcb Dec 16, 2024
37 checks passed
@ariellalgilmore ariellalgilmore deleted the fix/layer-stories-web-components branch December 16, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: @carbon/web-components @carbon/web-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Progress Bar With Layer doesn't work properly
3 participants