Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slider): resolve parity issue two handle feature #18450

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

sangeethababu9223
Copy link
Member

@sangeethababu9223 sangeethababu9223 commented Jan 28, 2025

Closes #17580

The two handle slider feature, available in React but missing in Web Components, is being added to Web Components.

Changelog

New

The two handle slider feature has been added.

Testing / Reviewing

Go to Slider stories in storybook and it should have a new Two handle slider story under it.

sangeethababu9223 and others added 23 commits January 7, 2025 12:10
Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 6d7dfe4
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67987c0aeda66c00083de443
😎 Deploy Preview https://deploy-preview-18450--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 6d7dfe4
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67987c0a2913fd000825b87f
😎 Deploy Preview https://deploy-preview-18450--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6d7dfe4
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67987c0a9836620009252590
😎 Deploy Preview https://deploy-preview-18450--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 6e43746
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67a04060dbb5e50008594da6
😎 Deploy Preview https://deploy-preview-18450--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 6e43746
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67a040608fe2d40008c1d7d5
😎 Deploy Preview https://deploy-preview-18450--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6e43746
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67a04060c3b7cb0008561314
😎 Deploy Preview https://deploy-preview-18450--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.16%. Comparing base (bc04c97) to head (6e43746).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18450   +/-   ##
=======================================
  Coverage   84.16%   84.16%           
=======================================
  Files         408      408           
  Lines       14450    14450           
  Branches     4666     4646   -20     
=======================================
  Hits        12162    12162           
- Misses       2123     2124    +1     
+ Partials      165      164    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sangeethababu9223 sangeethababu9223 marked this pull request as ready for review January 28, 2025 13:34
@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner January 28, 2025 13:34
@guidari
Copy link
Contributor

guidari commented Jan 31, 2025

Hey @sangeethababu9223
We can remove the Playground stories and add the controls to the Default stories instead.

@sangeethababu9223
Copy link
Member Author

Hey @sangeethababu9223 We can remove the Playground stories and add the controls to the Default stories instead.

Hey @guidari,
I've only worked on Two handle feature, that is why I've not removed the Playground story. For now I've added controls in Two handle story. I was thinking once the other missing features and complete parity check is done playground could be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider: Support two knobs
3 participants