Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web-extension-v2): remove package #317

Merged

Conversation

andy-blum
Copy link
Contributor

@andy-blum andy-blum commented May 22, 2024

Note

This PR is a part of my exploration into the devtools to understand how they work, how to update them for use with the next version of Carbon and carbon-based libraries, and how to make them more maintainable going forward. Full documentation is available here (w3ID required)

This PR is a followup to #286. Since firefox 121 and chrome 121, browsers are more forgiving with unrecognized keys in the manifest.json file's background property. (source)

With this limitation removed, all other APIs used by this extension appear to be cross-browser ready.

Changelog

Changed
  • web-extension v3 is compatible with chrome & firefox
Removed
  • web-extension v2 is removed

Testing / Reviewing

  • yarn install
  • yarn build
  • cd packages/web-extension
  • yarn launch:chrome or yarn launch:firefox
  • Ensure extension functionality works correctly

@motou
Copy link
Collaborator

motou commented May 22, 2024

Please take a look at the building phrase of the devtools since the PR check is failed.

@motou motou merged commit ca88734 into carbon-design-system:base May 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants