-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove default prop usage across components #1555
refactor: remove default prop usage across components #1555
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for gatsby-theme-carbon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for updating this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine but I'm not sure the defaults need stable references that live outside the function definition unless they're functions. carbon-design-system/carbon#10777
This is part of https://github.com/carbon-design-system/carbon-for-products-website/issues/360
We've been noticing lots of console errors, this contributes towards some specifically related to
defaultProp
usage, and it no longer being supported.Changelog
Changed