Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove default prop usage across components #1555

Merged

Conversation

matthewgallo
Copy link
Member

This is part of https://github.com/carbon-design-system/carbon-for-products-website/issues/360

We've been noticing lots of console errors, this contributes towards some specifically related to defaultProp usage, and it no longer being supported.

Changelog

Changed

packages/gatsby-theme-carbon/src/components/ArticleCard/ArticleCard.js
packages/gatsby-theme-carbon/src/components/AutolinkHeader/AutolinkHeader.js
packages/gatsby-theme-carbon/src/components/DoDontRow/DoDont.js
packages/gatsby-theme-carbon/src/components/FeatureCard/FeatureCard.js
packages/gatsby-theme-carbon/src/components/Footer/Footer.js
packages/gatsby-theme-carbon/src/components/GifPlayer/GifPlayer.js
packages/gatsby-theme-carbon/src/components/Grid/Grid.js
packages/gatsby-theme-carbon/src/components/Header/Header.js
packages/gatsby-theme-carbon/src/components/Homepage/Callout.js
packages/gatsby-theme-carbon/src/components/ImageCard/ImageCard.js
packages/gatsby-theme-carbon/src/components/ResourceCard/ResourceCard.js
packages/gatsby-theme-carbon/src/components/SquareCard/SquareCard.js
packages/gatsby-theme-carbon/src/components/Switcher/Switcher.js
packages/gatsby-theme-carbon/src/components/Video/Video.js

@matthewgallo matthewgallo requested review from eng618 and a team as code owners December 12, 2024 19:03
@matthewgallo matthewgallo requested review from tay1orjones and guidari and removed request for a team December 12, 2024 19:03
Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gatsby-theme-carbon 🛑 Canceled (Inspect) Dec 19, 2024 3:42pm

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for gatsby-theme-carbon ready!

Name Link
🔨 Latest commit 19951b6
🔍 Latest deploy log https://app.netlify.com/sites/gatsby-theme-carbon/deploys/676439c0b1f2e8000818a905
😎 Deploy Preview https://deploy-preview-1555--gatsby-theme-carbon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for updating this!

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but I'm not sure the defaults need stable references that live outside the function definition unless they're functions. carbon-design-system/carbon#10777

@alisonjoseph alisonjoseph merged commit 5d7ce66 into carbon-design-system:main Dec 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants