Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(playwright): check story has actually rendered before proceeding #4760

Conversation

matthewgallo
Copy link
Member

Contributes to #4688

I noticed that Cascade e2e avt test was passing even when it was being passed an incorrect story id which results in storybook's 404 page to display. This PR brings in similar changes @tay1orjones included in carbon-design-system/carbon#16132 after we chatted about this issue.

What did you change?

e2e/test-utils/storybook.js
packages/core/.storybook/preview.js
playwright.config.js

How did you test and verify your work?

  • Ran playwright tests locally
    • With an incorrect story id, fails
    • And with a correct one, passes

@matthewgallo matthewgallo added the type: infrastructure 🤖 Issues related to devops, builds, packaging label Apr 5, 2024
@matthewgallo matthewgallo requested a review from a team as a code owner April 5, 2024 14:32
Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 1683cb4
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/66100b6768708100088fcb87
😎 Deploy Preview https://deploy-preview-4760--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matthewgallo matthewgallo added this pull request to the merge queue Apr 5, 2024
Merged via the queue into carbon-design-system:main with commit af02de5 Apr 5, 2024
17 checks passed
@matthewgallo matthewgallo deleted the 4688-check-story-has-rendered-e2e-avt branch April 5, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: infrastructure 🤖 Issues related to devops, builds, packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants