Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add deprecation notice to userprofileimage #6223

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

davidmenendez
Copy link
Contributor

@davidmenendez davidmenendez commented Oct 15, 2024

Closes #4140 and #4074

adds .deprecated to UserProfileImage

@davidmenendez davidmenendez requested a review from a team as a code owner October 15, 2024 18:19
@davidmenendez davidmenendez requested review from elycheea and sangeethababu9223 and removed request for a team October 15, 2024 18:19
Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 3c1c433
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/673778d99f4bb6000895cf73
😎 Deploy Preview https://deploy-preview-6223--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 3c1c433
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/673778d9212bdd0008fad3aa
😎 Deploy Preview https://deploy-preview-6223--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@elycheea
Copy link
Contributor

@davidmenendez Do we want to close this for now or make it a draft? We shouldn’t be deprecating UserProfileImage until we’ve released the UserAvatar as stable.

@davidmenendez
Copy link
Contributor Author

@elycheea yes that's a great point. i'll move this to draft for now 👍

@davidmenendez davidmenendez marked this pull request as draft October 15, 2024 19:13
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.59%. Comparing base (27fc332) to head (3c1c433).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6223   +/-   ##
=======================================
  Coverage   79.58%   79.59%           
=======================================
  Files         394      394           
  Lines       12861    12862    +1     
  Branches     4266     4266           
=======================================
+ Hits        10236    10237    +1     
  Misses       2625     2625           
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)
---- 🚨 Try these New Features:

@elycheea
Copy link
Contributor

Keeping the blocked label here until we actually release user avatar (See #6469)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a deprecation notice on UserProfileImage
3 participants