-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(scrollgradient, stringformatter, truncatedlist, webterminal): csp #6346
base: main
Are you sure you want to change the base?
fix(scrollgradient, stringformatter, truncatedlist, webterminal): csp #6346
Conversation
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6346 +/- ##
==========================================
+ Coverage 79.61% 79.63% +0.02%
==========================================
Files 394 394
Lines 12871 12900 +29
Branches 4268 4273 +5
==========================================
+ Hits 10247 10273 +26
- Misses 2624 2627 +3
|
@AlexanderMelox still seeing some build failures. can you confirm if these are happening locally or just here? thanks. |
Closes #6191
This PR fixes CSP violations in the following components:
What did you change?
Removed inline styles, and added them with useIsomorphicEffect
How did you test and verify your work?
Storybook