-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Decouple lottie-web dependency from our repo #6477
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6477 +/- ##
==========================================
+ Coverage 79.85% 79.89% +0.03%
==========================================
Files 394 394
Lines 12877 12887 +10
Branches 4258 4265 +7
==========================================
+ Hits 10283 10296 +13
+ Misses 2594 2591 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw the code coverage dropped some. can you implement some tests for this? thanks!
Hey , added more coverage.
hi @amal-k-joy, Screen.Recording.2024-11-28.at.4.14.33.PM.mov |
Thanks for finding that out. Fixed that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Contributes #6366
Introduced new prop renderMedia to replace media prop
Deprecated media prop
How did you test and verify your work?
local