Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Decouple lottie-web dependency from our repo #6477

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

amal-k-joy
Copy link
Contributor

@amal-k-joy amal-k-joy commented Nov 20, 2024

Contributes #6366

Introduced new prop renderMedia to replace media prop
Deprecated media prop

How did you test and verify your work?

local

@amal-k-joy amal-k-joy requested a review from a team as a code owner November 20, 2024 05:26
@amal-k-joy amal-k-joy requested review from AlexanderMelox and devadula-nandan and removed request for a team November 20, 2024 05:26
Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 8d2eac4
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/674d9774c3afc400089d1520
😎 Deploy Preview https://deploy-preview-6477--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 8d2eac4
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/674d9774bd4b2200085f7d7b
😎 Deploy Preview https://deploy-preview-6477--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.89%. Comparing base (3f45528) to head (8d2eac4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6477      +/-   ##
==========================================
+ Coverage   79.85%   79.89%   +0.03%     
==========================================
  Files         394      394              
  Lines       12877    12887      +10     
  Branches     4258     4265       +7     
==========================================
+ Hits        10283    10296      +13     
+ Misses       2594     2591       -3     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

@elycheea elycheea added the dependencies Pull requests that update a dependency file label Nov 20, 2024
Copy link
Contributor

@davidmenendez davidmenendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw the code coverage dropped some. can you implement some tests for this? thanks!

Hey , added more coverage.

@devadula-nandan
Copy link
Contributor

devadula-nandan commented Nov 28, 2024

hi @amal-k-joy,
i noticed the animations were running twice, could you check that?
rest looks good to me.

Screen.Recording.2024-11-28.at.4.14.33.PM.mov

@amal-k-joy
Copy link
Contributor Author

hi @amal-k-joy, i noticed the animations were running twice, could you check that? rest looks good to me.

Screen.Recording.2024-11-28.at.4.14.33.PM.mov

Thanks for finding that out. Fixed that.

Copy link
Contributor

@devadula-nandan devadula-nandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants