Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Side Panel): storybook controls issue #6500

Conversation

sangeethababu9223
Copy link
Member

Closes #6479

Components in stories doesn't update with changed control values

What did you change?

Updated the side-panel.stories.ts file to make the changes made in control to reflect in the stories

How did you test and verify your work?

Storybook

@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner November 25, 2024 06:24
@sangeethababu9223 sangeethababu9223 requested review from matthewgallo and AlexanderMelox and removed request for a team November 25, 2024 06:24
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit c015cf5
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/6746ac174bab88000870e7d8
😎 Deploy Preview https://deploy-preview-6500--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit c015cf5
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6746ac17db0c5a0008d9561c
😎 Deploy Preview https://deploy-preview-6500--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.85%. Comparing base (1e8818f) to head (c015cf5).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6500   +/-   ##
=======================================
  Coverage   79.85%   79.85%           
=======================================
  Files         394      394           
  Lines       12877    12877           
  Branches     4258     4258           
=======================================
  Hits        10283    10283           
  Misses       2594     2594           
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

@elycheea elycheea changed the title fix(Side Panel Web components): storybook controls issue fix(Side Panel): storybook controls issue Nov 25, 2024
Copy link
Contributor

@elycheea elycheea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thank you for fixing this!

@sangeethababu9223 sangeethababu9223 added this pull request to the merge queue Dec 2, 2024
Merged via the queue into carbon-design-system:main with commit 19a7536 Dec 2, 2024
33 checks passed
@sangeethababu9223 sangeethababu9223 deleted the fix/sidepanel-web-components-storybook-control-issue branch December 2, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SidePanel in web components]: Components in stories doesn't update with changed control values
3 participants