Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ProductiveCard): add avt test coverage #6518

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

devadula-nandan
Copy link
Contributor

@devadula-nandan devadula-nandan commented Nov 29, 2024

Closes #6472

adds accessibility tests for productive card

Since we are in v12 OverflowMenu. i noticed that passing aria-label prop to v12 OverflowMenu spreads it to the overflow menu container which is a div and is reported as violation
v12 OverflowMenu uses single Label prop to set tooltip text on menu button and aria-label for list container (ul)
which means we might need to deprecate either iconDescription or overflowAriaLabel as Label prop handles both with v12 OverflowMenu.

useful references
#5803
#6395

i have passed label as below, and awaiting for any review suggestions

label={iconDescription || overflowAriaLabel}

What did you change?

e2e/components/ProductiveCard/ProductiveCard-test.avt.e2e.js
packages/ibm-products/src/components/Card/Card.tsx

How did you test and verify your work?

yarn avt

@devadula-nandan devadula-nandan requested a review from a team as a code owner November 29, 2024 14:38
@devadula-nandan devadula-nandan requested review from elycheea and anamikaanu96 and removed request for a team November 29, 2024 14:38
Copy link

netlify bot commented Nov 29, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit f1cfe3c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/674edfde7ed17200085d8473
😎 Deploy Preview https://deploy-preview-6518--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 29, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit f1cfe3c
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/674edfde2a43db0008c6435c
😎 Deploy Preview https://deploy-preview-6518--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.84%. Comparing base (9fdf057) to head (f1cfe3c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6518      +/-   ##
==========================================
- Coverage   79.85%   79.84%   -0.01%     
==========================================
  Files         394      394              
  Lines       12877    12878       +1     
  Branches     4258     4259       +1     
==========================================
  Hits        10283    10283              
- Misses       2594     2595       +1     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

@devadula-nandan devadula-nandan marked this pull request as draft December 2, 2024 13:30
@devadula-nandan devadula-nandan marked this pull request as ready for review December 3, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate ProductiveCard for WCAG 2.2 readiness
1 participant