fix: use correct github app installation id, in order to successfully get access token #6537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
matthewgallo
requested review from
elycheea,
kennylam and
a team
as code owners
matthewgallo
requested review from
anamikaanu96 and
davidmenendez
and removed request for
a team
davidmenendez
approved these changes
Dec 4, 2024
elycheea
approved these changes
Dec 4, 2024
Merged
via the queue into
carbon-design-system:main
with commit Dec 4, 2024
f432ae4
34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was revisiting the action for adding
status: one more reviewin our PRs and found that I accidentally left the installation id from the github app I created a while back for testing purposes. Instead, we want to use the installation id from the Carbon automation app, otherwise the action is currently attempting to authenticate on behalf of the github app I created for testing rather than Carbon automation.I added the correct installation id (the one for Carbon automation) to our repo secrets and it should be available to use now.
What did you change?
How did you test and verify your work?