-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Condition builder): correct and add more storybook data #6545
Merged
amal-k-joy
merged 8 commits into
carbon-design-system:main
from
amal-k-joy:conditionbuilderOct25
Dec 17, 2024
Merged
fix(Condition builder): correct and add more storybook data #6545
amal-k-joy
merged 8 commits into
carbon-design-system:main
from
amal-k-joy:conditionbuilderOct25
Dec 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amal-k-joy
requested review from
makafsal and
matthewgallo
and removed request for
a team
December 5, 2024 08:14
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6545 +/- ##
==========================================
- Coverage 79.97% 79.87% -0.10%
==========================================
Files 394 394
Lines 12894 12902 +8
Branches 4273 4273
==========================================
- Hits 10312 10306 -6
- Misses 2582 2596 +14
|
amal-k-joy
changed the title
fix(Condition builder): initial state getting reset on re-rendering
fix(Condition builder): correct and add more storybook data
Dec 9, 2024
matthewgallo
approved these changes
Dec 13, 2024
makafsal
approved these changes
Dec 16, 2024
Merged
via the queue into
carbon-design-system:main
with commit Dec 17, 2024
8301cc1
33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6556
Storybook data corrections
Added more inout config data for storybook
Updated testcases
How did you test and verify your work?
local