Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Condition builder): correct and add more storybook data #6545

Merged

Conversation

amal-k-joy
Copy link
Contributor

@amal-k-joy amal-k-joy commented Dec 5, 2024

Closes #6556
Storybook data corrections
Added more inout config data for storybook
Updated testcases

How did you test and verify your work?

local

@amal-k-joy amal-k-joy requested a review from a team as a code owner December 5, 2024 08:14
@amal-k-joy amal-k-joy requested review from makafsal and matthewgallo and removed request for a team December 5, 2024 08:14
Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 8688ebb
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/6756b12a3422f4000869e451
😎 Deploy Preview https://deploy-preview-6545--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 8688ebb
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6756b12a49c8570008367eb6
😎 Deploy Preview https://deploy-preview-6545--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amal-k-joy amal-k-joy marked this pull request as draft December 5, 2024 09:39
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.87%. Comparing base (6e58e9d) to head (8688ebb).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6545      +/-   ##
==========================================
- Coverage   79.97%   79.87%   -0.10%     
==========================================
  Files         394      394              
  Lines       12894    12902       +8     
  Branches     4273     4273              
==========================================
- Hits        10312    10306       -6     
- Misses       2582     2596      +14     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

@amal-k-joy amal-k-joy changed the title fix(Condition builder): initial state getting reset on re-rendering fix(Condition builder): correct and add more storybook data Dec 9, 2024
@amal-k-joy amal-k-joy marked this pull request as ready for review December 9, 2024 08:46
@amal-k-joy amal-k-joy removed the request for review from davidmenendez December 9, 2024 08:49
@amal-k-joy amal-k-joy added this pull request to the merge queue Dec 17, 2024
Merged via the queue into carbon-design-system:main with commit 8301cc1 Dec 17, 2024
33 checks passed
@amal-k-joy amal-k-joy deleted the conditionbuilderOct25 branch December 17, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Condition Builder : correct and refine storybook data
3 participants