Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(checklist): wcag2.2 readiness #6577

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

anamikaanu96
Copy link
Contributor

Closes #6528

  • Add tests for task states(checked, unchecked, indeterminate, disabled and error states) and tests for expanded/collapsed state.

  • Add avt test

What did you change?

packages/ibm-products/src/components/Checklist/Checklist.test.js
e2e/components/Checklist/Checklist-test.avt.e2e.js

How did you test and verify your work? yarn test

@anamikaanu96 anamikaanu96 requested a review from a team as a code owner December 12, 2024 10:17
@anamikaanu96 anamikaanu96 requested review from devadula-nandan and sangeethababu9223 and removed request for a team December 12, 2024 10:17
Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 1ea4350
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/67615dbf69347f0008b862c3
😎 Deploy Preview https://deploy-preview-6577--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 1ea4350
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/67615dbf89a69300082f5ceb
😎 Deploy Preview https://deploy-preview-6577--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.87%. Comparing base (36bd4f9) to head (1ea4350).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6577      +/-   ##
==========================================
+ Coverage   80.06%   80.87%   +0.80%     
==========================================
  Files         394      395       +1     
  Lines       12907    12876      -31     
  Branches     4277     4266      -11     
==========================================
+ Hits        10334    10413      +79     
+ Misses       2573     2463     -110     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

Copy link
Contributor

@devadula-nandan devadula-nandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add tab navigation for all the focusable elements, and verify if they are getting focused?

Copy link
Contributor

@devadula-nandan devadula-nandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a tiny change in comment

@matthewgallo matthewgallo added this pull request to the merge queue Dec 17, 2024
Merged via the queue into carbon-design-system:main with commit 9595f65 Dec 17, 2024
32 checks passed
@anamikaanu96 anamikaanu96 deleted the checklistAVT branch December 18, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate Checklist for WCAG 2.2 readiness
4 participants