build: remove vrt from ci.yml and run directly from netlify build script
#6578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6578 +/- ##
==========================================
- Coverage 79.96% 79.95% -0.02%
==========================================
Files 394 394
Lines 12899 12899
Branches 4274 4274
==========================================
- Hits 10315 10313 -2
- Misses 2584 2586 +2
|
matthewgallo
changed the title
vrt from ci.yml and run directly from netlify build script
matthewgallo
requested review from
elycheea,
kennylam and
a team
as code owners
davidmenendez
approved these changes
Dec 12, 2024
Merged
via the queue into
carbon-design-system:main
with commit Dec 12, 2024
20f5787
34 checks passed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run percy from netlify build script to avoid using hardcoded percy token directly in
.github/workflows/ci.yml.What did you change?
How did you test and verify your work?
Verified snapshots were still being taken from netlify logs.