fix(InterstitialScreen): onclose callback triggered twice #6582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amal-k-joy
requested review from
makafsal and
matthewgallo
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6582 +/- ##
==========================================
- Coverage 80.06% 80.05% -0.01%
==========================================
Files 394 394
Lines 12907 12907
Branches 4277 4277
==========================================
- Hits 10334 10333 -1
- Misses 2573 2574 +1
|
matthewgallo
approved these changes
Dec 16, 2024
devadula-nandan
approved these changes
Dec 17, 2024
Merged
via the queue into
carbon-design-system:main
with commit Dec 17, 2024
8361907
33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6443
What did you change?
onClose is already triggered by onClose of compose modal.
How did you test and verify your work?
local