fix(Emptystate): accessibility violation #6605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anamikaanu96
requested review from
elycheea and
amal-k-joy
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
amal-k-joy
requested changes
Dec 19, 2024
packages/ibm-products/src/components/EmptyStates/EmptyState.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6605 +/- ##
==========================================
+ Coverage 80.76% 80.78% +0.01%
==========================================
Files 396 396
Lines 12885 12893 +8
Branches 4267 4274 +7
==========================================
+ Hits 10407 10416 +9
+ Misses 2478 2477 -1
|
davidmenendez
approved these changes
Dec 30, 2024
Merged
via the queue into
carbon-design-system:main
with commit Dec 30, 2024
cc8f1aa
30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6352
Solutions for empty state accessibility violations
solution for issue 1 : Heading is now composable , introduced a new prop called
headingAsfor setting the value ofas.solution issue 2 : since the images are decorative, they have been hidden from assistive technology.
I had a discussion with Amal today regarding the conversation in the engineering huddle. We concluded that more appropriate solution will be using
asprop rather than using<Heading>without deprecating size prop.What did you change? All EmptyState files
How did you test and verify your work? storybook and Jaws