Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move AddImportNamespace() to the bottom of the file #4963

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

bricknerb
Copy link
Contributor

This function is used by import.cpp and import_cpp.cpp to deduplicate some of the logic.
However, it's not really part of the importing API, so it makes more sense to put it in the bottom.
In the .cpp, it was between static functions, just for easier reviewing of the refactoring PR (#4873).

Part of #4666.

This function is used by `import.cpp` and `import_cpp.cpp` to deduplciate some of the logic. However, it's not really part of the importing API, so it makes more sense to put it in the bottom. In the .cpp, it was between static functions, just for easier reviewing of the refactoring PR (carbon-language#4873).
Part of carbon-language#4666.
@jonmeow
Copy link
Contributor

jonmeow commented Feb 14, 2025

As I said before, I really don't think this move is an improvement. Can we please just leave it where it is, since that maintains history?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants