fix gap on ada mobile hero banner #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps the little triangular downwards pointing arrow should also be filled by Ada Lovelace's bust image instead of being filled by blue. In the same way that it looks when the website is resized to mobile proportions on a desktop computer. See this screenshot. Thank you ! |
|
@RayTracedObserver Yes that makes sense, thanks for the feedback! I've updated the after images in the main comment to show the latest update, moving the image down to cover the triangle as well. |
|
@tboltondev Awesome :) |
|
@katomm Could I get your review on this PR please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #111
Tested on device on iPhone 12:
Before:
After:
Tested using dev tools for Galaxy S8+:
Before:
After: