Skip to content

rc-2023-12-06

rc-2023-12-06: Rename `TokenName` to `AssetName`. (#4305)
@jonathanknowles jonathanknowles tagged this 06 Dec 07:44 
## Summary

This PR renames the `TokenName` type to `AssetName`, correcting a
terminological inconsistency between `cardano-wallet` and the [Cardano
Multi-Asset Ledger
Specification](https://github.com/input-output-hk/cardano-ledger/releases/latest/download/mary-ledger.pdf).

## Details

The [Cardano Multi-Asset Ledger
Specification](https://github.com/input-output-hk/cardano-ledger/releases/latest/download/mary-ledger.pdf)
uses the term `AssetName`:

>
![mary-ledger-asset-name](https://github.com/cardano-foundation/cardano-wallet/assets/206319/988c61bc-dbb0-4f45-97e4-14fab3f6f839)

The `cardano-wallet` HTTP REST API also uses the derived terms
`assetName` and `asset_name`:
>
https://github.com/cardano-foundation/cardano-wallet/blob/85b7a721778ba0034b8eab3533de3b513cd9a937/specifications/api/swagger.yaml#L7165

>
https://github.com/cardano-foundation/cardano-wallet/blob/85b7a721778ba0034b8eab3533de3b513cd9a937/specifications/api/swagger.yaml#L1028

However, the equivalent `cardano-wallet` Haskell type was called
`TokenName`.

This PR corrects this discrepancy, and:
- renames `TokenName` to `AssetName`;
- renames related functions, strings, and comments;
- **avoids** making any change to database schemas;
- **avoids** making any change to the HTTP REST API.
Assets 2
Loading