Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Half UI change + page transitions + others (progress) #56

Closed
wants to merge 4 commits into from

Conversation

weebjs
Copy link

@weebjs weebjs commented Jul 31, 2024

No description provided.

@weebjs weebjs requested a review from sohamjaiswal as a code owner July 31, 2024 05:01
Copy link
Member

@sohamjaiswal sohamjaiswal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also sync the fork and merge changes

Comment on lines -87 to -103
<hr />
<nav class="list-nav p-4 -m-4 max-h-64 lg:max-h-[500px] overflow-y-auto">
<form method="post" action="/?/setTheme" use:enhance={setTheme}>
<ul>
<!-- , badge -->
{#each themes as { icon, name, type }}
<li>
<button
class="option w-full h-full"
type="submit"
name="theme"
value={type}
class:bg-primary-active-token={$storeTheme === type}
>
<span>{icon}</span>
<span class="flex-auto text-left">{name}</span>
<!-- {#if badge}<span class="badge variant-filled-secondary">{badge}</span>{/if} -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still want these there, dont remove these

@sosweetham sosweetham added the enhancement New feature or request label Jul 31, 2024
@sosweetham
Copy link
Member

closed in lieu of #60

@sosweetham sosweetham closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants