Skip to content

Commit

Permalink
Using proper image (knative-extensions#134)
Browse files Browse the repository at this point in the history
Co-authored-by: Chris Suszyński <[email protected]>
  • Loading branch information
2 people authored and serverless-qe committed Dec 23, 2021
1 parent 117c983 commit 323c889
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 16 deletions.
5 changes: 0 additions & 5 deletions pkg/cli/ics/constants.go

This file was deleted.

13 changes: 2 additions & 11 deletions pkg/sender/in_cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package sender

import (
"fmt"
"regexp"

cloudevents "github.com/cloudevents/sdk-go/v2"
batchv1 "k8s.io/api/batch/v1"
Expand All @@ -11,6 +10,7 @@ import (
"knative.dev/kn-plugin-event/pkg/cli/ics"
"knative.dev/kn-plugin-event/pkg/event"
"knative.dev/kn-plugin-event/pkg/k8s"
"knative.dev/kn-plugin-event/pkg/metadata"
)

type inClusterSender struct {
Expand Down Expand Up @@ -44,7 +44,7 @@ func (i *inClusterSender) Send(ce cloudevents.Event) error {
RestartPolicy: corev1.RestartPolicyNever,
Containers: []corev1.Container{{
Name: "kn-event-sender",
Image: imageFor("kn-event-sender"),
Image: metadata.ResolveImage(),
Env: []corev1.EnvVar{{
Name: "K_SINK",
Value: url.String(),
Expand All @@ -63,12 +63,3 @@ func (i *inClusterSender) Send(ce cloudevents.Event) error {
}
return nil
}

func imageFor(artifact string) string {
basename := ics.ContainerBasename
r := regexp.MustCompile(".+[A-Za-z0-9]$")
if r.MatchString(basename) {
basename += "/"
}
return basename + artifact
}

0 comments on commit 323c889

Please sign in to comment.