Fix stripe client ref id to be alphanumeric

cardstack · Nov 20, 2024 · b46ff74 · b46ff74
1 parent 4ecfc5a
commit b46ff74
Show file tree

Hide file tree

Showing 5 changed files with 35 additions and 8 deletions.
diff --git a/packages/billing/stripe-webhook-handlers/checkout-session-completed.ts b/packages/billing/stripe-webhook-handlers/checkout-session-completed.ts
@@ -30,9 +30,14 @@ export async function handleCheckoutSessionCompleted(
     const matrixUserName = event.data.object.client_reference_id;
 
     if (matrixUserName) {
+      const base64UserId = matrixUserName.replace(/-/g, '+').replace(/_/g, '/');
+      const decodedMatrixUserName = Buffer.from(
+        base64UserId,
+        'base64',
+      ).toString('utf8');
       await updateUserStripeCustomerId(
         dbAdapter,
-        matrixUserName,
+        decodedMatrixUserName,
         stripeCustomerId,
       );
     }

diff --git a/packages/host/app/services/billing-service.ts b/packages/host/app/services/billing-service.ts
@@ -4,8 +4,16 @@ import ENV from '@cardstack/host/config/environment';
 const { stripePaymentLink } = ENV;
 
 export default class BillingService extends Service {
+  encodeToAlphanumeric(matrixUserId: string) {
+    return Buffer.from(matrixUserId)
+      .toString('base64')
+      .replace(/\+/g, '-')
+      .replace(/\//g, '_')
+      .replace(/=+$/, '');
+  }
+
   getStripePaymentLink(matrixUserId: string): string {
-    const clientReferenceId = Buffer.from(matrixUserId).toString('base64');
+    const clientReferenceId = this.encodeToAlphanumeric(matrixUserId);
     return `${stripePaymentLink}?client_reference_id=${clientReferenceId}`;
   }
 }
diff --git a/packages/matrix/helpers/index.ts b/packages/matrix/helpers/index.ts
@@ -599,7 +599,7 @@ export async function setupPayment(
   page?: Page,
 ) {
   // decode the username from base64
-  const decodedUsername = Buffer.from(username, 'base64').toString('utf8');
+  const decodedUsername = decodeFromAlphanumeric(username);
 
   // mock trigger stripe webhook 'checkout.session.completed'
   let freePlan = await realmServer.executeSQL(
@@ -689,7 +689,7 @@ export async function setupUserSubscribed(
   username: string,
   realmServer: IsolatedRealmServer,
 ) {
-  const matrixUserId = Buffer.from(username).toString('base64');
+  const matrixUserId = encodeToAlphanumeric(username);
   await setupUser(username, realmServer);
   await setupPayment(matrixUserId, realmServer);
 }
@@ -760,3 +760,16 @@ export async function waitUntil<T>(
   }
   throw new Error('Timeout waiting for condition');
 }
+
+export function encodeToAlphanumeric(string: string) {
+  return Buffer.from(string)
+    .toString('base64')
+    .replace(/\+/g, '-')
+    .replace(/\//g, '_')
+    .replace(/=+$/, ''); // Remove padding
+}
+
+export function decodeFromAlphanumeric(encodedString: string) {
+  const base64 = encodedString.replace(/-/g, '+').replace(/_/g, '/');
+  return Buffer.from(base64, 'base64').toString('utf8');
+}
diff --git a/packages/matrix/tests/registration-with-token.spec.ts b/packages/matrix/tests/registration-with-token.spec.ts
@@ -26,6 +26,7 @@ import {
   enterWorkspace,
   showAllCards,
   setupUser,
+  encodeToAlphanumeric,
 } from '../helpers';
 import { registerUser, createRegistrationToken } from '../docker/synapse';
 
@@ -109,7 +110,7 @@ test.describe('User Registration w/ Token - isolated realm server', () => {
     });
 
     // base 64 encode the matrix user id
-    const matrixUserId = Buffer.from('@user1:localhost').toString('base64');
+    const matrixUserId = encodeToAlphanumeric('@user1:localhost');
 
     await assertPaymentSetup(page, matrixUserId);
     await setupPayment(matrixUserId, realmServer, page);
@@ -201,8 +202,7 @@ test.describe('User Registration w/ Token - isolated realm server', () => {
       page.locator('[data-test-setup-payment-message]'),
     ).toContainText('Setup your payment method now to enjoy Boxel');
 
-    const user2MatrixUserId =
-      Buffer.from('@user2:localhost').toString('base64');
+    const user2MatrixUserId = encodeToAlphanumeric('@user2:localhost');
 
     await assertPaymentSetup(page, user2MatrixUserId);
     await setupPayment(user2MatrixUserId, realmServer, page);

diff --git a/packages/matrix/tests/registration-without-token.spec.ts b/packages/matrix/tests/registration-without-token.spec.ts
@@ -18,6 +18,7 @@ import {
   assertPaymentSetup,
   setupPayment,
   registerRealmUsers,
+  encodeToAlphanumeric,
 } from '../helpers';
 
 test.describe('User Registration w/o Token', () => {
@@ -69,7 +70,7 @@ test.describe('User Registration w/o Token', () => {
     );
 
     // base 64 encode the matrix user id
-    const matrixUserId = Buffer.from('@user1:localhost').toString('base64');
+    const matrixUserId = encodeToAlphanumeric('@user1:localhost');
 
     await assertPaymentSetup(page, matrixUserId);
     await setupPayment(matrixUserId, realmServer, page);