Catalog entry create saving should be consistent #1076
Conversation
tintinthong
changed the title
tintinthong
force-pushed
the
cs-6308-catalog-entry-create-should-be-consistent
branch
from
5e5e539 to
a513096
Compare
This reverts commit 57f0dcc.
tintinthong
force-pushed
the
cs-6308-catalog-entry-create-should-be-consistent
branch
from
75b7c8f to
25c3048
Compare
| // if this is a newly created card from auto-save then we | ||
| // need to replace the stack item to account for the new card's ID | ||
| if (!item.card.id && updatedCard.id) { | ||
| await item.setCardURL(new URL(updatedCard.id)); | ||
| } | ||
| return; | ||
| } | ||
|
|
||
| if (item.isLinkedCard) { | ||
| this.operatorModeStateService.trimItemsFromStack(item); // closes the 'create new card' editor for linked card fields | ||
| } else { | ||
| if (!item.card.id && updatedCard.id) { | ||
| this.operatorModeStateService.trimItemsFromStack(item); | ||
| } else { | ||
| this.operatorModeStateService.replaceItemInStack( | ||
| item, | ||
| item.clone({ | ||
| request, | ||
| format: 'isolated', | ||
| }), | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
Made a change of fix have "Finish Editing" act consistently
Previous behavior
When you clicked 'Finish Editing' on a newly created linksTo card, the edit modal of the new card will close and the parent card will be displayed with the newly linked card embedded. This seemed unexpected
https://discord.com/channels/584043165066199050/900021750367129641/1216738379425648710
Boxel Meeting Notes
So only after looking at this image I recall that Chris did say that the UI looks wonky for this and he wanted the Previous behavior
But imo, the buttons make more sense with this change. If you want to skip to just seeing the parent card with the newly created card embedded, you can just click "Close"
| super(owner, args); | ||
| // initializes to false | ||
| if (this.args.model === undefined) { | ||
| this.args.set(false); |
There was a problem hiding this comment.
same comment here
| super(owner, args); | ||
| // initializes to 'actual' | ||
| if (!this.args.model) { | ||
| this.args.set('actual'); |
There was a problem hiding this comment.
This was triggering auto-save. Which is why there was an inconsistency in the behaviour of the new cards. They were "saved" sometimes upon being created.
There was a problem hiding this comment.
I renamed this entire file to solve issue with sourcemap and debugging. Basically, I wouldn't be able to trace my debugger properly since there are 2 files operator-mode-test.
| Positional: [model: boolean | null, inputType: boolean]; | ||
| get checkedId() { | ||
| return String(this.args.model); | ||
| } | ||
| }; | ||
| } |
| static async [deserialize]<T extends BaseDefConstructor>( | ||
| this: T, | ||
| val: any, | ||
| ): Promise<BaseInstanceType<T>> { | ||
| if (val === undefined || val === null) { | ||
| return false as BaseInstanceType<T>; | ||
| } | ||
| return Boolean(val) as BaseInstanceType<T>; | ||
| } |
There was a problem hiding this comment.
Since we may possibly have null in the JSON but may want to display a default value for certain components. We stub a default value via the deserialize hook. This doesn't trigger editing of the card in the constructor.
I think there is compelling use-case for this. For example, like when displaying calendar date
| @@ -204,58 +216,32 @@ class ImageSizeField extends FieldDef { | |||
| static edit = class Edit extends Component<typeof this> { | |||
| <template> | |||
| <div class='radio-group' data-test-radio-group={{@fieldName}}> | |||
| <label for='{{this.radioGroup}}_actual'> | |||
There was a problem hiding this comment.
Perhaps, I shud work on fixing the component to be vertical vs horizontal given the spacing of the parent.
tintinthong
requested review from
a team,
backspace,
FadhlanR,
lukemelia,
habdelra,
burieberry and
jurgenwerk
| @@ -167,6 +167,7 @@ export default class InteractSubmode extends Component<Signature> { | |||
| doc, | |||
| relativeTo, | |||
| ); | |||
| await here.cardService.saveModel(here, newCard); | |||
There was a problem hiding this comment.
Actually I do sus if this is the correct owner?
There was a problem hiding this comment.
it should be ok, it bascially means that the live updates for the newCard will continue to be received while the interact-submode-component is in scope.
delete-merged-branch
bot
deleted the
cs-6308-catalog-entry-create-should-be-consistent
branch
This PR saves the card immediately (the card has an id) upon choosing a new catalog entry from cards-grid AND upon choosing a new catalog entry from linking a new card. It doesn't trigger auto-save rather it saves the card purely from the create card action
Previous behaviour
Upon choosing catalog entry (the modal opens), the card is not saved and it doesn't have an id. It is not until you edit a field that the card will be created via auto-save.
Screen.Recording.2024-03-13.at.20.14.51.mov