-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiple overlapping card in a stack due to spam clicking #1087
Fix multiple overlapping card in a stack due to spam clicking #1087
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not able to reproduce this locally, but I tried double clicking on current staging where things are currently not the fastest and I was able to reproduce this by a quick double click on the grid item where 2 of the same cards opened on the stack.
I am wondering if this could be solved by changing the type of viewCard task from restartable to drop (i.e. ignore subsequent attempts if the attempted card did not open yet)
It works using dropTask and I updated the test. 7f01263 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. I think it seems right to use dropTask
Ticket: CS-6590
This PR addresses an issue where multiple overlapping cards could appear in a stack if the user spam-clicked the card grid item. To prevent this, I've implemented a mechanism to disallow multiple cards with the same ID from being opened in a stack. Additionally, if there are duplicate cards in a stack, the latest one will be opened at the top of the stack. While it's unlikely that we'd need multiple cards with the same ID in a stack, I'm open to exploring alternative approaches to resolve this issue.Based on @jurgenwerk 's feedback, I updated the approach to solve this issue by using
dropTask
.