Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use workspace instead of realm in UI #1093

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Use workspace instead of realm in UI #1093

merged 3 commits into from
Mar 18, 2024

Conversation

FadhlanR
Copy link
Contributor

Before:
image

After:
Screenshot 2024-03-14 at 17 14 28

@FadhlanR FadhlanR requested a review from a team March 14, 2024 10:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 14, 2024 •
edited
Loading

Test Results

531 tests  +3   527 ✔️ +3   7m 18s ⏱️ -1s
    1 suites ±0       4 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 528dd2a. ± Comparison against base commit ccee10c.

♻️ This comment has been updated with latest results.

tintinthong
tintinthong approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@tintinthong tintinthong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a skim thru for possible places. I actually think this does cover all in the UI

@backspace
Copy link
Contributor

backspace commented Mar 14, 2024 •
edited
Loading

I found another use!

Monosnap 2024-03-14 13-12-02

Also this alt text and this.

And `catalog-entry.gts':

Boxel 2024-03-14 13-27-53

I couldn’t figure out how to get to this in the UI but realm-dropdown.gts.

Maybe this use is fine to leave for now…?

@FadhlanR FadhlanR merged commit 4eed5de into main Mar 18, 2024
18 checks passed
@delete-merged-branch delete-merged-branch bot deleted the cs-6603-dont-use-realm-in-ui branch March 18, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tintinthong tintinthong tintinthong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FadhlanR @backspace @tintinthong