Add Queue interface and BrowserQueue implementation #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
habdelra
commented
Mar 15, 2024
Comment on lines
+3
to
+16
| export type Expression = (string | Param)[]; | ||
|
|
||
| export type PgPrimitive = | ||
| | number | ||
| | string | ||
| | boolean | ||
| | JSON.Object | ||
| | JSON.Arr | ||
| | null; | ||
|
|
||
| export interface Param { | ||
| param: PgPrimitive; | ||
| kind: 'param'; | ||
| } |
There was a problem hiding this comment.
this will be very handy in the future when we start making sql expressions, for now we just the PgPrimitive
habdelra
requested review from
lukemelia,
backspace,
IanCal,
jurgenwerk,
tintinthong,
FadhlanR,
burieberry and
ef4
backspace
approved these changes
Mar 15, 2024
Should we make this the version specified for Volta? |
I have no strong feelings on this |
jurgenwerk
approved these changes
Mar 18, 2024
delete-merged-branch
bot
deleted the
cs-6459-review-home-grown-job-queue-implementation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Queue interface that both the browser queue and the node queue (based on postgres) will implement. (99.99% of this diff in is the lock file which are mostly deletions--so don't be intimidated to review). BTW I'm using pnpm version 8.15.4. it looks like it wanted to do some serious cleanup....